Enable NFD rule for GPU resource driver Helm chart #68
Conversation
oxxenix
changed the title
oxxenix
changed the title
oxxenix
force-pushed
the
gpu-nfd-rule
branch
2 times, most recently
from
cd15249 to
e5bd563
Compare
| - labels: | ||
| gpu.intel.com/product: "Max_1100" | ||
| labelsTemplate: "gpu.intel.com/device.count={{"{{"}} len .pci.device {{"}}"}}" | ||
| - labelsTemplate: "gpu.intel.com/device.count={{"{{"}} len .pci.device {{"}}"}}" |
There was a problem hiding this comment.
I did not notice this earlier, but there are 4 rules for different sets of GPU IDs, each producing the same gpu.intel.com/device.count=<count> label. Which won't produce correct results on node which has GPUs from multiple rule sets.
While this is not a problem for GPU plugin because it does not support nodes with different types of Intel GPUs, DRA GPU driver is supposed to support support such use-case too.
I think it's best just to remove these rules completely for now...
There was a problem hiding this comment.
thanks! I removed these rules
oxxenix
force-pushed
the
gpu-nfd-rule
branch
from
dd26f4a to
abc96af
Compare
| tolerations: [] | ||
| nodeSelector: {} | ||
| nodeSelector: | ||
| intel.feature.node.kubernetes.io/gpu: "true" |
There was a problem hiding this comment.
This label will exist only with NFD. I think it's better to wrap it inside nfd.enabled check in the DaemonSet template, and remove or leave this empty (in case user wants for some reason to use his/her own label instead of NFD one):
| intel.feature.node.kubernetes.io/gpu: "true" | |
| # label used when nfd.enabled is true | |
| #intel.feature.node.kubernetes.io/gpu: "true" |
oxxenix
force-pushed
the
gpu-nfd-rule
branch
2 times, most recently
from
efc0923 to
32991a4
Compare
oxxenix
force-pushed
the
gpu-nfd-rule
branch
from
32991a4 to
478b0bc
Compare
|
Default image tag value in README.md is outdated. |
No description provided.